https://bugzilla.redhat.com/show_bug.cgi?id=2131842



--- Comment #3 from Mattia Verga <mattia.ve...@proton.me> ---
(In reply to Gwyn Ciesla from comment #2)
> I've added %{?_isa} to the -devel Requires, anything else?

See the Issues section of my review. The shared library must be versioned
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning
(`Under no circumstances should the unversioned library be shipped in Fedora`)
and the COPYING file must be marked with `%license` instead of `%doc`.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2131842
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to