https://bugzilla.redhat.com/show_bug.cgi?id=2141867
Wayne Sun <g...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mhron...@redhat.com
--- Comment #3 from Wayne Sun <g...@redhat.com> ---
This is informal review as I'm not sponsored.
The license in the spec is GPL-2.0-only, and in upstream repo:
In the setup.py:
https://github.com/gforcada/flake8-builtins/blob/master/setup.py#L29
https://github.com/gforcada/flake8-builtins/blob/master/setup.py#LL49C14-L49C29
It matches as no "later" specified in the license field.
With rpmlint, there are warning with invalid-license GPL-2.0-only:
# rpmlint srpm/python-flake8-builtins.spec
=================================================================== rpmlint
session starts
===================================================================
rpmlint: 2.2.0
configuration:
/usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1
# rpmlint srpm/python-flake8-builtins-2.0.1-2.fc38.src.rpm
=================================================================== rpmlint
session starts
===================================================================
rpmlint: 2.2.0
configuration:
/usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1
python-flake8-builtins.src: W: invalid-license GPL-2.0-only
# rpmlint results/python3-flake8-builtins-2.0.1-2.fc38.noarch.rpm
=================================================================== rpmlint
session starts
===================================================================
rpmlint: 2.2.0
configuration:
/usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1
python3-flake8-builtins.noarch: W: invalid-license GPL-2.0-only
==================================== 1 packages and 0 specfiles checked; 0
errors, 1 warnings, 0 badness; has taken 0.0 s
====================================
@Miro GPL-2.0-only is in the allowed license list for fedora:
https://docs.fedoraproject.org/en-US/legal/allowed-licenses/
is it correct?
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2141867
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
