https://bugzilla.redhat.com/show_bug.cgi?id=2165224

Fabio Valentini <decatho...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+
           Assignee|nob...@fedoraproject.org    |decatho...@gmail.com
             Status|NEW                         |POST
                 CC|                            |decatho...@gmail.com
           Doc Type|---                         |If docs needed, set a value



--- Comment #2 from Fabio Valentini <decatho...@gmail.com> ---
Oh, another library that was rewritten from C in Rust. :D

Reading the upstream README, I recommend that use use cargo-c to build the
shared library.
In my experience, it is the least painful option for building C-style shared
libraries, especially because it handles setting SONAME and generating headers
and pkg-config files.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Once releng has processed the unretirement, please also request an f37 branch
for this package. It makes it much easier for Rust SIG members to update things
if there's not "holes" (i.e. this package would be present in rawhide and f36,
but not f37, which would be weird). I also recommend to re-enable tracking for
the package in koschei for the rawhide and f37 branches once they have been
created.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2165224
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to