Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=665560 --- Comment #16 from Minnikhanov <minnikha...@gmail.com> 2011-01-27 12:18:56 EST --- Spec URL: http://dl.dropbox.com/u/14118661/rubygem-mail.spec SRPM URL: http://dl.dropbox.com/u/14118661/rubygem-mail-2.2.14-5.fc14.src.rpm (In reply to comment #14) > * Could you put the BuildRequires you just added onto separate lines. A style > things yes, and not a blocker, but still I feel it makes it more legible + Fixed. (I saw like that anywhere, nothing else) > * Why did you add the sections in %prep to "fix anything executable that > doesn't have a shebang" and "find files with a shebang that don't have > executable permissions". Looking at the gem there are no executable files nor > files that should be so I'm not sure what these blocks are trying to > accomplish > + Fixed. Remove these. > * rpmlint complains about a missing %clean section, could you please add it, > even if it is empty > - Not need by Comment 15. > * building the rpm results in an error stating the LICENSE.rdoc file cannot be > found. Where are you getting this? If no such file exists could you please > remove it from the %files section > + Fixed. (sorry) > * additionally building the rpm outputs that the Gemfile.lock file is not > listed in %files. Furthermore the Gemfile is listed as a file in the doc > subpackage, which is incorrect as its needed by the mail runtime. Please put > both Gemfile and Gemfile.lock in the main package %files section (not marked > as > %doc either) + Fixed. There is not 'Gemfile.lock' in upstream - create this file by 'touch' in %prep. Is this right? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
