Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=668820 --- Comment #2 from Vít Ondruch <vondr...@redhat.com> 2011-01-31 12:01:50 EST --- * Please consider updating to the latest version (3.5.1 atm) * MUST: The License field in the package spec file must match the actual license. - Please review the licensing. At appears that the package is GPLv2 and some custom license, where some files are MIT (lib/rdoc/task.rb) or Ruby licensed * Cleaning - %clean section is no longer needed (on Fedora): https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean * Documentation - Please do not disable documentation generation, since ruby forces installation of ruby-rdoc, therefore rdoc should be available prior the gem installation - Please consider to provide the documentation in -doc subpackage * Requires - BuildRequires: rubygem(minitest) is needed for text execution * Tests - Please execute test suite using following command: ruby -I../lib -e "Dir.glob('test/test_*').each {|t| require t}" This allows you to avoid build dependency on rake, hoe, rubyforge and neither ZenTest is required IMO. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
