https://bugzilla.redhat.com/show_bug.cgi?id=2209759
Tom Rix <t...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tstel...@redhat.com
Status|NEW |ASSIGNED
Flags| |needinfo?(tstellar@redhat.c
| |om)
--- Comment #2 from Tom Rix <t...@redhat.com> ---
The documentation could be improved by adding
BuildRequires: doxygen
Lots of docs will be generated.
A change to fix the no executable stack
diff --git a/rocclr.spec b/rocclr.spec
index 0752e05..73fb54e 100644
--- a/rocclr.spec
+++ b/rocclr.spec
@@ -10,7 +10,7 @@
Name: rocclr
Version: %{rocm_version}
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: ROCm Compute Language Runtime
Url: https://github.com/ROCm-Developer-Tools/clr
License: MIT
@@ -152,6 +152,7 @@ sed -i "s|\(/usr/bin/\)env perl|\1perl|"
HIP-rocm-%{version}/bin/hipcc.pl
%build
%cmake \
+ -DCMAKE_SHARED_LINKER_FLAGS=-Wl,-z,noexecstack \
-DHIP_COMMON_DIR=$(realpath HIP-rocm-%{version}) \
-DCMAKE_INSTALL_LIBDIR=%{_lib} \
-DHIP_PLATFORM=amd \
@@ -251,5 +252,8 @@ fi
%exclude %{_datadir}/hip/samples
%changelog
+* Sun May 28 2023 Tom Rix <t...@redhat.com> - 5.5.0-2
+- Add noexecstack linker option
+
* Tue May 16 2023 Jeremy Newton <alexjnewt at hotmail dot com> - 5.5.0-1
- Initial package
A couple of things. in the config step of this package
-- ROCm Agent Enumurator Not Found
BuildRequires and Requires should have rocminfo package
I am testing by building rocBLAS, so far i have had to
export DEVICE_LIB_PATH=/usr/lib64/amdgcn/bitcode
there should be a automatic connect between where rocm-device-libs installs
this bitcode dir
and where hipcc/clang picks them up with '--rocm-device-lib-path'
Tom Stellar what do you think ?
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2209759
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
