https://bugzilla.redhat.com/show_bug.cgi?id=2173178
Benson Muite <benson_mu...@emailplus.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |POST
Flags|fedora-review? |fedora-review+
|needinfo?(benson_muite@emai |
|lplus.org) |
--- Comment #47 from Benson Muite <benson_mu...@emailplus.org> ---
Thanks for the changes.
a) In the spec file, the line
Patch:
https://invent.kde.org/system/%{name}/-/commit/efbf77b480c2f5a8c40fadfd169a916a51363a23.diff
should be just
Patch: efbf77b480c2f5a8c40fadfd169a916a51363a23.diff
Urls are only needed for files that will not be put into dist-git. The patch
can also be named
so that one can understand what it does, for example fix-translations.patch
b) In the spec file, rather than globbing:
%{_datadir}/dbus-1/*
please use
%{_datadir}/dbus-1/system-services/org.kde.kded.inotify.service
%{_datadir}/dbus-1/system.d/org.kde.kded.inotify.conf
Please make the changes upon import.
Approved.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2173178
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
