Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542436 --- Comment #13 from BJ Dierkes <wdier...@rackspace.com> 2011-01-31 18:26:47 EST --- (In reply to comment #12) > You should probably open up a new review request instead of reopening a old > new > since the reports counting reviews processes will get confused otherwise and > you shouldn't assign the review request to yourself. I don't really follow why I should create a new tracker for this. Seems more efficient to take it over since the original owner dropped it rather than having duplicates. > > * Should document why you are using the git version instead of the release in > the spec file Done. Noted that, the git version is not a 'git clone' of the repo in place of an official tarbal, but rather that github uses the tagg'ed git version when generating the tarbal. > > * Should document the patch and their upstream status This was applied upstream, and now removed. > > * No need to define the buildroot or have a clean section unless you are > branching for EPEL This will be branched for EPEL. SPEC: http://5dollarwhitebox.org/fedora/python-cloudfiles.spec SRPMS: http://5dollarwhitebox.org/fedora/python-cloudfiles-1.7.7-1.fc14.src.rpm $ rpmlint -i SPECS/python-cloudfiles.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint -i RPMS/noarch/python-cloudfiles-1.7.7-1.fc14.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
