Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521909 Ruediger Landmann <r.landm...@redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |r.landm...@redhat.com AssignedTo|nob...@fedoraproject.org |r.landm...@redhat.com Flag| |fedora-review? --- Comment #38 from Ruediger Landmann <r.landm...@redhat.com> 2011-02-01 00:39:23 EST --- Thanks Pavel -- it looks like you've addressed all the concerns that Michael raised about this package. It builds fine for F14 and F15 Just two more little issues: 1. Because it looks like we cannot build this package for EPEL5, we can now drop: * the Buildroot: declaration * the cleaning of the Buildroot from %install * the whole %clean section 2. We can clean up the English expression in %description doc to say: ======== API documentation and example code to try the %{name} library. It also contains a Makefile that builds all the examples with a single command. WARNING: To build the included examples of code, you must have the %{name}-devel package installed. Install the %{name}-devel package manually if you plan to compile these examples. ======== Beyond that, the package looks good to me: - = N/A / = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [/] Rpmlint output is clean: $ rpmlint SPECS/ne7ssh.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint SRPMS/ne7ssh-1.3.2-9.fc14.src.rpm ne7ssh.src: W: spelling-error %description -l ru своё -> свои, свое, свор 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint RPMS/x86_64/ne7ssh-1.3.2-9.fc14.x86_64.rpm ne7ssh.x86_64: W: spelling-error %description -l ru своё -> свои, свое, свор 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint RPMS/x86_64/ne7ssh-devel-1.3.2-9.fc14.x86_64.rpm ne7ssh-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint RPMS/noarch/ne7ssh-doc-1.3.2-9.fc14.noarch.rpm ne7ssh-doc.noarch: W: spelling-error %description -l en_US devel -> delve, devil, revel 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint RPMS/x86_64/ne7ssh-debuginfo-1.3.2-9.fc14.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [/] Package is named according to the Package Naming Guidelines. [/] Spec file name must match the base package %{name}, in the format %{name}.spec. [/] Package meets the Packaging Guidelines including the Language specific items [/] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [/] License field in the package spec file matches the actual license. License type: QPL [/] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [/] Spec file is legible and written in American English. [/] Sources used to build the package matches the upstream source, as provided in the spec URL. $ md5sum SOURCES/ne7ssh-1.3.2.tar.bz2 3f9ce5b8414177fc5bbcce6332238658 SOURCES/ne7ssh-1.3.2.tar.bz2 $ md5sum ~/Download/ne7ssh-1.3.2.tar.bz2 3f9ce5b8414177fc5bbcce6332238658 /home/rlandmann/Download/ne7ssh-1.3.2.tar.bz2 [/] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=2754031 [/] Package is not known to require ExcludeArch [/] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly (with the %find_lang macro) [/] ldconfig called in %post and %postun if required. [/] Package does not bundle copies of system libraries [/] Package is not relocatable. [/] Package must own all directories that it creates. [/] Package does not contain duplicates in %files. [/] Permissions on files are set properly [/] %files section includes a %defattr(...) line [/] Package consistently uses macros. [/] Large documentation files are in a -doc subpackage, if required. [/] Package uses nothing in %doc for runtime. [/] Header files in -devel subpackage, if present. [-] Static libraries in -static subpackage, if present. [/] Development .so files in -devel subpackage, if present. [/] -devel packages require base package with full versioning. [/] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [/] Package does not own files or directories owned by other packages. [/] Filenames are valid UTF-8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
