https://bugzilla.redhat.com/show_bug.cgi?id=2211987
--- Comment #6 from Tim Flink <tfl...@redhat.com> ---
(In reply to Jeremy Newton from comment #5)
<snip>
>
> Generic:
> [x]: Rpmlint is run on all installed packages.
> Note: No rpmlint messages.
>
> > It looks like the permission issue was already fixed
Yeah, it was an artifact of rpmautospec being run on my local system. I posted
more details on devel list if you're interested in the details
> ===== NOTES =====
>
> The only issue is that there's no owner of %{_datadir}/rocm
> I suggest either:
> - if it will be used by other future ROCm packages: make a sub-package
> called "rocm-filesystem" to own this
> OR
> - if it will be the only user of this directory: just change
> "%{_datadir}/rocm/cmake" in %files to "%{_datadir}/rocm"
I assumed that something else was using %{_datadir}/rocm and purposely didn't
claim it in this package but didn't think about leaving the parent unowned.
I installed AMD's packages on a VM and the only thing that showed up in
/opt/rocm/share/rocm is cmake. From this, I infer that nothing else in the
stack uses %{_datadir}/rocm
I've changed the %files section so that %{_datadir}/rocm is claimed. If it
turns out that something else really does use that dir, we can revisit and
change the package at that time.
Spec URL: https://tflink.fedorapeople.org/packages/rocm-cmake/rocm-cmake.spec
SRPM URL:
https://tflink.fedorapeople.org/packages/rocm-cmake/rocm-cmake-5.5.1-4.fc39.src.rpm
COPR Build:
https://copr.fedorainfracloud.org/coprs/tflink/rocm-packaging/build/6018432/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2211987
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202211987%23c6
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
