https://bugzilla.redhat.com/show_bug.cgi?id=2233188

Robert-André Mauchin 🐧 <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nob...@fedoraproject.org    |zebo...@gmail.com
              Flags|                            |fedora-review?
                   |                            |needinfo?(m...@flyn.org)
             Status|NEW                         |ASSIGNED



--- Comment #2 from Robert-André Mauchin 🐧 <zebo...@gmail.com> ---

 - error: File not found:
/builddir/build/BUILDROOT/golang-modernc-ccgo-4-3.16.15-1.fc40.x86_64/usr/share/doc/golang-modernc-ccgo-4/README.md

->

find . ! \( -name v4 -o -name _build  -o -name LICENSE -o -name AUTHORS -o
-name CONTRIBUTORS -o -name README.md \) -maxdepth 1 -exec rm -rvf {} \;



 -> Don't add %global debug_package %{nil} if you build the binary. In general
just build the binary for one of the version of ccgo, ideally the latest, but
here since there is no official v4, i'd stick with the v3. So drop the binary
in this package.

- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Please take my comments into account.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2233188

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202233188%23c2
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to