https://bugzilla.redhat.com/show_bug.cgi?id=2234761



--- Comment #5 from Kalev Lember <klem...@redhat.com> ---
(In reply to Fabio Valentini from comment #2)
> Two minor issues:
> 
> 1. It looks like you disabled schemars and zerocopy support, please remember
> to import the rust2rpm.conf file you used as well.

Yes, of course, I already had it commited locally.

> 2. The summary is too long, from rpmlint:
> 
> Please trim to something shorter (maybe "Convenient representation of
> four-character-code values").
> Not sure what four-character-code is though, so ... feel free to come up
> with something better.

Thanks, fixed! I went with "Newtype wrapper for representing
four-character-code values" -
https://src.fedoraproject.org/rpms/rust-four-cc/c/978a1ac79dc2c520eb51971b500768c79a89487f?branch=rawhide


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2234761

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202234761%23c5
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to