Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676188

Martin Gieseking <martin.giesek...@uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.giesek...@uos.de

--- Comment #2 from Martin Gieseking <martin.giesek...@uos.de> 2011-02-14 
15:57:42 EST ---
(In reply to comment #1)
> - Although your package doesn't install SVG icons, the %post and %postun 
> macros
> refer to the SVG folder. Don't know what to do in this case, I assume the
> folder path has to be changed to the correct installation folder of the icon.

Right. The spec file in the SRPM differs from the one given as a separate URL.
The latter installs an SVG rather than a PNG.

The proper scriptlets to update the icon cache are listed here:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache


Here are some additional comments:

- according to the source file headers, the license is GPLv2+

- adapt Source0 according to 
  http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

- replace the suffix .1.gz with .1* in %files since we should not rely on a 
  concrete compression format 

- I recommend to replace %{_datadir}/man with %{_mandir}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to