https://bugzilla.redhat.com/show_bug.cgi?id=2244402
--- Comment #5 from Sandro <gui...@penguinpee.nl> --- (In reply to Benson Muite from comment #4) > The prep section should not do more than use commands such as mv, rm, sed > etc. > > ant ebcdic compiles the java file at: > https://github.com/roskakori/CodecMapper/tree/master/source/at/roskakori/ > codecmapper > and then generates the codec files: > https://github.com/roskakori/CodecMapper/blob/master/build.xml#L43 > > It should therefore be in the build section. Since SHOULD does not mean a mandatory requirement, I feel I'm still within my liberties to diverge. Could you point me to a relevant section of the packaging guidelines, so I can read up on it? > > For the url, it is sufficient to have: > URL: https://github.com/roskakori/CodecMapper I chose the somewhat longer URL since that has the `README.rst` displayed and gives information relevant to `EBCDIC`. But I'm fine with using `%forgeurl` instead, since the package does need code from `CodecMapper` to be useful. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2244402 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244402%23c5 _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
