https://bugzilla.redhat.com/show_bug.cgi?id=2249060
--- Comment #4 from Jan Staněk <jsta...@redhat.com> ---
(In reply to Stephen Gallagher from comment #3)
> Issues:
> =======
> - This package either needs to depend on nodejs or it needs to own
> `%{nodejs_sitelib}` in %files. Otherwise, this package won't be installable.
Correction – the package would be installable (tested with
nodejs-cjs-module-lexer, where I also missed this),
but the `%{nodejs_sitelib}` would not be removed on uninstall, instead being
kept empty on the system.
I'm letting the packages to (co-)own the directory; I really do not wish to
tangle the dependencies more
(nodejs will depend on them).
> - The patch we're carrying needs to have a comment pointing to the upstream
> proposal.
Added link to the spec file.
Spec URL:
https://download.copr.fedorainfracloud.org/results/jstanek/nodejs-undici/fedora-rawhide-x86_64/06632093-nodejs-undici/nodejs-undici.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/jstanek/nodejs-undici/fedora-rawhide-x86_64/06632093-nodejs-undici/nodejs-undici-5.27.2-3.fc40.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2249060
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202249060%23c4
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
