Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=670608 Martin Gieseking <martin.giesek...@uos.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.giesek...@uos.de --- Comment #2 from Martin Gieseking <martin.giesek...@uos.de> 2011-02-18 08:40:13 EST --- In addition to Mario's informal review: - According to the source file headers, libgaiagraphics is licensed under LGPLv3+. File COPYING contains the GPLv3 license text. Please adapt the License field and ask upstream to provide the correct license text with the tarball. - I recommend to use macro %{version} in Source0 to simplify future updates. - Add a short comment above Patch0 telling what the patch does. - Please be more specific in %files, especially if only single files are added. This helps to prevent accidentally packaging unwanted files: %{_libdir}/libgaiagraphics.so.* %{_includedir}/gaiagraphics.h %{_libdir}/libgaiagraphics.so %{_libdir}/pkgconfig/gaiagraphics.pc - If you want to maintain the package for EPEL < 6 too, add Requires: pkgconfig to the -devel subpackage. Otherwise, you can drop all the buildroot stuff. $ rpmlint /var/lib/mock/fedora-14-i386/result/*.rpm libgaiagraphics.i686: W: spelling-error %description -l en_US Libgaigraphics -> Stratigraphical, Calligraphic, Stratigraphic libgaiagraphics.i686: W: shared-lib-calls-exit /usr/lib/libgaiagraphics.so.1.0.0 exit@GLIBC_2.0 libgaiagraphics.src: W: spelling-error %description -l en_US Libgaigraphics -> Stratigraphical, Calligraphic, Stratigraphic libgaiagraphics-devel.i686: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 4 warnings. - fix the spelling error as per Mario's comment - shared-lib-calls-exit can be ignored but should possibly be fixed upstream - no-documentation is expected and can be ignored -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
