Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678442 Sergio Belkin <seb...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |seb...@gmail.com --- Comment #3 from Sergio Belkin <seb...@gmail.com> 2011-02-21 13:28:42 EST --- Hi Hedayat, I am (still) not from packager group, however I hope you find my quick review useful: Did you run rpmlint on rpm files? 1. Either you should add she-bang on top of /usr/share/os-prober/common.sh or better (in this case viewing that are functions) remove executable bits for that file: Consider that eg: /etc/init.d/functions has no executable bits and http://fedoraproject.org/wiki/Common_Rpmlint_issues#script-without-shebang 2. Scripts lacks of man pages, that's not mandatory but perhaps you can talk and help with the author Joey Hess about it. HTH Greetings -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
