https://bugzilla.redhat.com/show_bug.cgi?id=2266310
Fabio Valentini <decatho...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |decatho...@gmail.com
--- Comment #6 from Fabio Valentini <decatho...@gmail.com> ---
Quick comments from a Rust packaging perspective:
1. Please replace "__cargo_is_lib() 0" (which is a private macro and was
previously needed as a workaround) with "cargo_install_lib 0" (which is now the
official, supported way to override this behaviour as of rust-packaging v26).
2. Bump cargo-rpm-macros dependency to >= 26 (and / or regenerate the spec with
rust2rpm v26).
3. Please include the full output of "%cargo_license_summary" from the
build.log as a spec comment above the "License" tag.
4. The license tag contains duplicates and can be simplified.
> (MIT OR Apache-2.0) AND Unicode-DFS-2016 AND Apache-2.0 AND (Apache-2.0 OR
> BSL-1.0) AND (Apache-2.0 OR MIT) AND GPL-2.0-or-later AND MIT AND (MIT OR
> Apache-2.0) AND MPL-2.0 AND MPL-2.0+ AND (Unlicense OR MIT)
Eliminating duplicates and sorting results in:
Apache-2.0 AND GPL-2.0-or-later AND MIT AND MPL-2.0 AND MPL.2.0+ AND
Unicode-DFS-2016 AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR MIT) AND
(Unlicense OR MIT)
Looks good from Rust perspective otherwise.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2266310
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202266310%23c6
--
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
