Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=649802 Christos Triantafyllidis <christos.triantafylli...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christos.triantafyllidis@gm | |ail.com --- Comment #3 from Christos Triantafyllidis <christos.triantafylli...@gmail.com> 2011-03-04 13:28:50 EST --- Hi David, i did a quick review on this, i have only 3 comments: a) rpmlint on spec file returns an easy solvable warning: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 18) b) I see that you have a requirement for "rt3" but i think that the real requirement (at least according to the perl sources) is for "perl(RT::Interface::Email)" which indeed is provided by rt3. c) I think that "BuildArch: noarch" is not needed. Regards, Christos PS: I can't act as reviewer so take my comments as advices. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
