Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682545

Carlo Teubner <ct.spamma...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ct.spamma...@gmail.com

--- Comment #4 from Carlo Teubner <ct.spamma...@gmail.com> 2011-03-06 15:16:32 
EST ---
You need to use desktop-file-install:
http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

There's no need to explicitly list sqlite and gtk2 as "Requires:". The version
of sqlite that came with Fedora 14 is 3.6.23.1, and for gtk2 it's 2.22.0. Since
you appear to target F14 only, an explicit requires is unnecessary, and indeed
discouraged in the guidelines:
http://fedoraproject.org/wiki/Packaging/Guidelines#Requires

BuildRoot is unnecessary:
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

%clean is unnecessary:
http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to