Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680205 --- Comment #9 from Hans de Goede <hdego...@redhat.com> 2011-03-08 13:03:08 EST --- (In reply to comment #8) <snip> > - Added/removed suggested BuildRequires. I didn't have libXpm-devel installed > until my RPM failed to build with the new BuildRequires, though I was still > able to build before. Was it just excluding features automatically or > something? Yes, just like it was automatically excluding dumb support. > - Used globs to simplify %files section. In addition to al_*.3* manpages, > there > are also ALLEGRO_*.3* manpages. Can a glob like that be used for those too Yes! > - The top of allegro5.cfg says that in UNIX it can be located at > /etc/allegro5rc so I've added %install commands to move it there with some > guidance from #fedora-devel. We'll see if I did it properly with the next > review. :-X > Sounds good. > As for the libcurl-devel dependency, I borrowed that from one of the upstream > developers' Debian-based build tutorial: > > http://wiki.allegro.cc/index.php?title=Install_Allegro5_From_SVN/Linux/Debian > > I asked #allegro on freenode today and one of the developers told me that one > of the example programs can be made to use libcurl. So it's probably not > necessary right now. Agreed lets drop it. > That made me think that maybe I should create a subpackage > for the example programs, but without the source code to examine their only > real use is testing that Allegro is installed and working. I guess I could > always create the subpackage for the binaries and users interested in the > source of the examples could fetch it separately... What do you think? You could take a shot at it, but creating sub packages for example code often is a pain (because example programs tend to not be made to get installed into an FHS location, so they end up not being able to find their data files, etc.). Not worth the effort IMHO. Talking about "example" programs, are there any tools with allegro5 which we maybe should package (Like the allegro4 grabber program) ? > > Some of my previous changes were made at home and apparently I forgot to push > them to my GitHub repository so I'll wait until I merge those before > publishing > a new revision. :) Ok, I'll do another review pass once you've posted your new version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review