Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=682905 Terje Røsten <terje...@phys.ntnu.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |terje...@phys.ntnu.no --- Comment #3 from Terje Røsten <terje...@phys.ntnu.no> 2011-03-08 14:34:01 EST --- Some comments: a) no url tag, where is this project living? b) you might want to add the sha1 8ad98e3 to the tarball name? c) -n %{name}-%{version} in %setup is the default and can be dropped (however, consider b)) d) mixing of $RPM_BUILD_ROOT and %{buildroot}, pick one. e) use macros for /etc, /sbin and /etc/init.d/ f) target is a very generic name, possible problem g) change %defattr(-,root,root) -> %defattr(-,root,root,-) h) the package seems to be free for docs and with no url tag, the user will have a hard time be able to use this utility. i) Release: 1, please add disttag here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
