Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684475

Martin Gieseking <martin.giesek...@uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.giesek...@uos.de

--- Comment #3 from Martin Gieseking <martin.giesek...@uos.de> 2011-03-13 
08:57:47 EDT ---
Some further notes on the latest spec:

- please use a more neutral and less biased %description, e.g. the one from 
  dockapps.org:
  "wmblob shows some blobs moving around. It does nothing useful, it's just 
  a toy."

- replace the iconv lines with the following loop to ensure a correct
conversion
  and to preserve the timestamps:

  for f in ChangeLog README doc/wmblob.1 doc/how_it_works; do
    iconv -f iso-8859-1 -t utf8 $f >$f.tmp && \
    touch -r $f $f.tmp && \
    mv $f.tmp $f
  done

- replace the make statement with this one to apply the %optflags during the 
  build:
  make CFLAGS="%{optflags} `pkg-config --cflags gtk+-2.0`" %{?_smp_mflags}

  configure.ac looks pretty messy and could need some maintenance. ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to