https://bugzilla.redhat.com/show_bug.cgi?id=2368535



--- Comment #5 from Akira TAGOH <[email protected]> ---
A few questions/comments after looking roughly:

* There are no strict rules for font meta packages at the moment though, what's
the reason you didn't simply follow the default naming rule of %fontmetapkg
macro and have an own name of ektype-baloo-2-all?  The default name is obvious
from its package name that it is a meta package for font but ektype-baloo-2-all
isn't.

* Indic fonts are categorized under "Fonts with less common encodings" in
/usr/share/fontconfig/templates/fontconfig-priorities.txt from
fonts-rpm-templates. Using 60 in config file is too high. that breaks default
font sets. Recommended priority number for optional fonts would be between 66
and 69.

* You shouldn't abbrivate a generic family name like sans in your config. it
should be sans-serif.

* You don't need to test "en" for "lang" in your config. I don't think it works
as expected.

* For ektype-ballo-2-fonts.conf, multiple test elements means AND operator. I
think what you want to do is to have multiple <match>es per lang.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2368535

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202368535%23c5

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to