Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690282 Stanislav Ochotnicky <socho...@redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |socho...@redhat.com --- Comment #18 from Stanislav Ochotnicky <socho...@redhat.com> 2011-04-07 09:28:57 EDT --- Also: * Group for javadoc should be Documentation, plus we normally use "API documentation for %{name}" as description/summary * gluegen/make/lib contains binary files (jars). Not sure if they are used during build, but should be removed in %prep to be sure * It's a good idea to leave a blank line between changelogs :-) * It would be nice if the patches would be commented upon (why there are needed, their upstream status etc.) This is just from a quick glance at the spec, I'm sure Alex will do a more thorough review after the fixes... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
