https://bugzilla.redhat.com/show_bug.cgi?id=2432458
Artur Frenszek-Iwicki <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #5 from Artur Frenszek-Iwicki <[email protected]> --- > BuildArch: noarch > BuildRequires: gcc You should remove the "BuildArch: noarch" bit here and move it to be a property of the devel sub-package. The way it is now, koji (the Fedora build system) will see that the package is noarch, pick a random builder of a random architecture, and build it there. This means that tests will be ran only on a single architecture. If you keep the main package archful and mark the devel sub-package as noarch, then koji will build it (and hence, test it) on all architectures. This will still produce only a single devel.noarch package. > %description > ... > %description devel Since the main package is empty, building this spec will produce only the devel subpackage. As such, you may consider moving the longer and more descriptive description to the devel subpackage. > %check > gcc -Wall -Wextra -I include -o test_gstr test/test_gstr.c You should add %{optflags} (or ${CFLAGS}) to the invocation to ensure that Fedora's compiler flags are used when building the test suite. Alternatively, since the upstream repo contains a Makefile, you could add "BuildRequires: make" and just run "%make_build test" here. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432458 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432458%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
