https://bugzilla.redhat.com/show_bug.cgi?id=2437215



--- Comment #5 from Davide Cavalca <[email protected]> ---
> Release: 1%{?dist}

Consider using rpmautospec given that this is a new package

> # Automatically converted from old format: ASL 2.0 - review is highly 
> recommended.
> License: Apache-2.0

Audit that the license is actually correct and drop the comment if it is

> %description

This needs to be wrapped to 80 columns

> %check

You need to add the stuff you're using to buildrequires (tar, grep, xargs
(which iirc comes from findutils or the like?))

> %doc %{gem_instdir}/LICENSE

This needs to be %license


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2437215

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437215%23c5

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to