https://bugzilla.redhat.com/show_bug.cgi?id=2437514
--- Comment #3 from Andrew Bauer <[email protected]> --- > a) Please add %dir %{_includedir}/%{srcname} to the devel files list Done. > b) Consider using %{forgesource} macros I don't expect to switch this package from a git snapshot to a release. Consequently, I see no benefit to using forgesource macros. > c) Consider building main.cpp in the check section: Good catch. I failed to scroll to the end of the Readme. PR to add a cmake test to the upstream project was created and then merged by upstream: https://github.com/chmike/CxxUrl/pull/17 ctest macro has been in added the specfile > d) Consider using %{autorelease} and %{autochangelog} macros Honestly, I can't stand these macros. Call me old fashioned, but I want to see the changelog in the specfile. I don't want to use git or browse somewhere to see this information. >e) Version field should be: >Version: 0.3^%{commit_date}git%{commit_short}%{dist} Ah, it seems I didn't realize snapshot version control changed. I've updated the Version tag to: 0.3^%{commit_date}git%{commit_short} The %{dist} suffix needs to remain in the Release tag. UPDATED Spec URL ---------------- https://download.copr.fedorainfracloud.org/results/kni/cxxurl/fedora-rawhide-x86_64/10129548-cxxurl/cxxurl.spec UPDATED SRPM URL ---------------- https://download.copr.fedorainfracloud.org/results/kni/cxxurl/fedora-rawhide-x86_64/10129548-cxxurl/cxxurl-0.3%5E20260214gite81b86e-1.fc45.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2437514 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437514%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
