https://bugzilla.redhat.com/show_bug.cgi?id=2440002
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #6 from Ben Beasley <[email protected]> --- I found no issues, and the package is APPROVED. It looks like you could easily update to 0.5.0, which was released four days ago, and this would allow you to drop several patches. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is generated by rust2rpm, simplifying the review. There are several additions and deviations from the “no-rust2rpm.toml” output. --- +# prevent library files from being installed +%global cargo_install_lib 0 […] - -%package devel […] -%ghost %{crate_instdir}/Cargo.toml This is sensible, as the crate library doesn’t appear to be designed for external use. --- -Version: 0.5.0 +Version: 0.4.0 A newer version, 0.5.0, was released four days ago. Looking at https://gitlab.com/sequoia-pgp/sequoia-git/-/compare/v0.4.0...v0.5.0?from_project_id=42240924, it seems like there are no obvious dependency issues, and upgrading would mean you no longer have to patch the git2, toml, and vergen dependencies. Consider updating, if there isn’t some obstacle I’ve missed. --- +# Manually created patch for downstream crate metadata changes +# * switch crypto backend from Nettle to OpenSSL Sensible and in line with the general preference for OpenSSL in Fedora. +# * bump git2 dependency from v0.19 to v0.20 +# * bump toml dependency from v0.8 to v0.9 +# * drop noop vergen build-dependency Sensible; no longer needed from 0.5.0. +Patch: sequoia-git-fix-metadata.diff +# * proposed fixes for shell completion generation logic +Patch2: https://gitlab.com/sequoia-pgp/sequoia-git/-/merge_requests/100.patch Sensible, well-justified, and has an upstream link. The PR was merged and included in 0.5.0, so you can drop the patch if you are able to update. +# * drop references to vergen (no git repository state available) +Patch3: 0001-drop-references-to-vergen.patch Sensible, but also no longer necessary in 0.5.0 since the vergen dependency was removed upstream. --- -BuildRequires: cargo-rpm-macros >= 24 +BuildRequires: cargo-rpm-macros >= 26 +%if %{with check} +BuildRequires: faketime +BuildRequires: git-core +%endif This looks good: specifying non-crate test dependencies. --- -# FIXME: paste output of %%cargo_license_summary here -License: # FIXME +# (Apache-2.0 OR MIT) AND BSD-3-Clause […] +# bzip2-1.0.6 +License: %{shrink: + LGPL-2.0-or-later + AND Apache-2.0 […] + AND (Unlicense OR MIT) +} This is necessary, and it appears that you’ve constructed the SPDX expression correctly. --- +%{_mandir}/man1/sq-git* +%{bash_completions_dir}/sq-git.bash +%{fish_completions_dir}/sq-git.fish +%{zsh_completions_dir}/_sq-git […] %install %cargo_install +# install manual pages +mkdir -p %{buildroot}/%{_mandir}/man1 +cp -pav target/assets/man-pages/sq-git*.1 %{buildroot}/%{_mandir}/man1/ +# install shell completions +install -Dpm 0644 target/assets/shell-completions/sq-git.bash \ + %{buildroot}/%{bash_completions_dir}/sq-git.bash +install -Dpm 0644 target/assets/shell-completions/sq-git.fish \ + %{buildroot}/%{fish_completions_dir}/sq-git.fish +install -Dpm 0644 target/assets/shell-completions/_sq-git \ + %{buildroot}/%{zsh_completions_dir}/_sq-git Installing man pages and tab completion support is good, and it’s done properly here. --- %build +export ASSET_OUT_DIR=target/assets Makes sense. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Library General Public License v2 or later". 76 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2440002-rust-sequoia- git/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 14885 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. Tests pass. I did not play with it interactively. [!]: Latest version is packaged. Version 0.5.0 is available, and updating could allow us to drop several patches. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=142677085 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: sequoia-git-0.4.0-1.fc45.x86_64.rpm rust-sequoia-git-0.4.0-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpela0vy8u')] checks: 32, packages: 2 sequoia-git.x86_64: E: incorrect-fsf-address /usr/share/licenses/sequoia-git/LICENSE.txt 2 packages and 0 specfiles checked; 1 errors, 0 warnings, 8 filtered, 1 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 sequoia-git.x86_64: E: incorrect-fsf-address /usr/share/licenses/sequoia-git/LICENSE.txt 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 4 filtered, 1 badness; has taken 0.1 s Source checksums ---------------- https://crates.io/api/v1/crates/sequoia-git/0.4.0/download#/sequoia-git-0.4.0.crate : CHECKSUM(SHA256) this package : b09db8fddf6dbd4445223a5d9c88e7114979eb85117dd5189289530d4863566b CHECKSUM(SHA256) upstream package : b09db8fddf6dbd4445223a5d9c88e7114979eb85117dd5189289530d4863566b Requires -------- sequoia-git (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) libsqlite3.so.0()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) Provides -------- sequoia-git: sequoia-git sequoia-git(x86-64) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2440002 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Java, Python, Perl, fonts, SugarActivity, Ocaml, R, Haskell, C/C++, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2440002 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202440002%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
