https://bugzilla.redhat.com/show_bug.cgi?id=2432005
Peter Lemenkov <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #14 from Peter Lemenkov <[email protected]> --- Actually it's in a good state already. There are lots of rpmlint warning and even errors but all of them can be explained by a special treatment of the package( special group, security parameters, etc). I wouldn't consider them as a blockers, so here is my formal Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/licenses/opkssh See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ^^^ guess this could be a false positive since all the licensing is done using standard macros. - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'Apache-2.0 AND BSD-2-Clause AND BSD-3-Clause AND ISC AND MIT AND Unlicense'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 ^^^ This is definitaly a false positive. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. ^^^ Generated automatically. [x]: License file installed when any subpackage combination is installed. [+/-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec but I don;t believe it's practical in our case. [x]: Package requires other packages for directories it uses. [x]: Package owns all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [+/-]: Package contains bundled libraries as usual for golang ones. [x]: Changelog in prescribed format (%autochangelog). [x]: Sources contain only permissible code or content. [x]: %config files are marked noreplace or the reason is justified. [-]: Not a GUI application. [-]: No development files. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: The package is not a rename of another package. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package does not contain systemd file(s). [x]: Useful -debuginfo package. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. ^^^ This is actually a false positive. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages is not necessary. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in opkssh- server , opkssh-server-selinux [?]: I did not test if the package functions as described. [x]: Latest version is packaged (0.13.0). [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Sources werent verified with gpgverify. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) ^^^ Spec-file was regenerated locally. This is false-positive. [x]: Rpmlint is run on debuginfo package(s). [x]: Rpmlint is run on all installed packages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: opkssh-0.13.0-1.fc44.x86_64.rpm opkssh-server-0.13.0-1.fc44.noarch.rpm opkssh-server-selinux-0.13.0-1.fc44.noarch.rpm opkssh-doc-0.13.0-1.fc44.noarch.rpm opkssh-0.13.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp8lkgn_5p')] checks: 32, packages: 5 opkssh-server-selinux.noarch: W: zero-perms-ghost Suggestion: "%ghost %attr(0644,root,root) /var/lib/selinux/targeted/active/modules/200/opkssh" opkssh-server.noarch: E: useless-provides group(opkssh) ^^^ False positive opkssh.spec: W: specfile-warning warning: Macro expanded in comment on line 34: %{archivename}-vendor.tar.bz2 opkssh.spec: W: specfile-warning warning: /tmp/rpmlint.opkssh-0.13.0-1.fc44.src.rpm.uceq3qjg/opkssh.spec line 87: autopatch: no matching patches in range ^^^ Survivable. opkssh-server.noarch: W: only-non-binary-in-usr-lib opkssh-server.noarch: W: non-standard-gid /etc/opk/auth_id opkssh opkssh-server.noarch: W: non-standard-gid /etc/opk/providers opkssh opkssh-server.noarch: E: non-readable /etc/opk/auth_id 640 opkssh-server.noarch: E: non-readable /etc/opk/providers 640 opkssh-server.noarch: E: non-readable /etc/ssh/sshd_config.d/60-opkssh.conf 600 opkssh-server.noarch: E: non-readable /etc/sudoers.d/opkssh 440 opkssh.x86_64: W: no-manual-page-for-binary opkssh opkssh.x86_64: W: no-documentation opkssh-server.noarch: W: no-documentation opkssh-server-selinux.noarch: W: no-documentation opkssh.spec:34: W: macro-in-comment %{archivename} opkssh.x86_64: W: files-duplicate /usr/share/licenses/opkssh/vendor/github.com/openpubkey/openpubkey/LICENSE /usr/share/licenses/opkssh/LICENSE opkssh.x86_64: W: files-duplicate /usr/share/licenses/opkssh/vendor/modules.txt /usr/share/licenses/opkssh/modules.txt opkssh-server.noarch: W: empty-%pre opkssh-server-selinux.noarch: W: dangerous-command-in-%pre cp opkssh-server-selinux.noarch: W: dangerous-command-in-%postun rm opkssh-server-selinux.noarch: W: dangerous-command-in-%posttrans rm opkssh-server-selinux.noarch: W: dangerous-command-in-%post rm opkssh-server.noarch: W: conffile-without-noreplace-flag /etc/ssh/sshd_config.d/60-opkssh.conf opkssh-server.noarch: W: conffile-without-noreplace-flag /etc/sudoers.d/opkssh 5 packages and 0 specfiles checked; 5 errors, 20 warnings, 139 filtered, 5 badness; has taken 1.8 s Rpmlint (debuginfo) ------------------- Checking: opkssh-debuginfo-0.13.0-1.fc44.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpi_1uyys_')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 1.0 s Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 opkssh-server-selinux.noarch: W: zero-perms-ghost Suggestion: "%ghost %attr(0644,root,root) /var/lib/selinux/targeted/active/modules/200/opkssh" opkssh-server.noarch: E: useless-provides group(opkssh) opkssh.x86_64: W: unused-direct-shlib-dependency /usr/bin/opkssh /lib64/libresolv.so.2 opkssh-server-selinux.noarch: W: read-error [Errno 21] Is a directory: '/var/lib/selinux/targeted/active/modules/200/opkssh' opkssh-server.noarch: W: only-non-binary-in-usr-lib opkssh-server.noarch: W: non-standard-gid /etc/opk/auth_id opkssh opkssh-server.noarch: W: non-standard-gid /etc/opk/providers opkssh opkssh-server.noarch: E: non-readable /etc/opk/auth_id 640 opkssh-server.noarch: E: non-readable /etc/opk/providers 640 opkssh-server.noarch: E: non-readable /etc/ssh/sshd_config.d/60-opkssh.conf 600 opkssh-server.noarch: E: non-readable /etc/sudoers.d/opkssh 440 opkssh.x86_64: W: no-manual-page-for-binary opkssh opkssh-server-selinux.noarch: W: no-documentation opkssh-server.noarch: W: no-documentation opkssh.x86_64: W: no-documentation opkssh.x86_64: W: files-duplicate /usr/share/licenses/opkssh/vendor/github.com/openpubkey/openpubkey/LICENSE /usr/share/licenses/opkssh/LICENSE opkssh.x86_64: W: files-duplicate /usr/share/licenses/opkssh/vendor/modules.txt /usr/share/licenses/opkssh/modules.txt opkssh-server.noarch: W: empty-%pre opkssh-server-selinux.noarch: W: dangerous-command-in-%pre cp opkssh-server-selinux.noarch: W: dangerous-command-in-%postun rm opkssh-server-selinux.noarch: W: dangerous-command-in-%posttrans rm opkssh-server-selinux.noarch: W: dangerous-command-in-%post rm opkssh-server.noarch: W: conffile-without-noreplace-flag /etc/ssh/sshd_config.d/60-opkssh.conf opkssh-server.noarch: W: conffile-without-noreplace-flag /etc/sudoers.d/opkssh 5 packages and 0 specfiles checked; 5 errors, 19 warnings, 141 filtered, 5 badness; has taken 0.7 s Source checksums ---------------- https://github.com/openpubkey/opkssh/archive/v0.13.0/opkssh-0.13.0.tar.gz : CHECKSUM(SHA256) this package : 7b0180c8bda0df15c627a99a105e41f76d421c19a8f7f8f256da7eb2fec991b5 CHECKSUM(SHA256) upstream package : 7b0180c8bda0df15c627a99a105e41f76d421c19a8f7f8f256da7eb2fec991b5 https://thofmann.fedorapeople.org/opkssh/opkssh-0.13.0-vendor.tar.bz2 : CHECKSUM(SHA256) this package : 6b281b02341ab230779d376926bbc9b842e6e36fdcc4b37774cda38ac2072109 CHECKSUM(SHA256) upstream package : 6b281b02341ab230779d376926bbc9b842e6e36fdcc4b37774cda38ac2072109 Requires -------- opkssh (rpmlib, GLIBC filtered): libc.so.6()(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH) opkssh-server (rpmlib, GLIBC filtered): (opkssh-server-selinux if selinux-policy-targeted) /bin/sh config(opkssh-server) group(opkssh) opkssh opkssh-server-selinux (rpmlib, GLIBC filtered): /bin/sh selinux-policy-targeted opkssh-doc (rpmlib, GLIBC filtered): Provides -------- opkssh: bundled(golang(dario.cat/mergo)) bundled(golang(filippo.io/bigmod)) bundled(golang(github.com/Azure/go-ansiterm)) bundled(golang(github.com/Microsoft/go-winio)) bundled(golang(github.com/awnumar/memcall)) bundled(golang(github.com/awnumar/memguard)) bundled(golang(github.com/bmatcuk/doublestar/v4)) bundled(golang(github.com/cenkalti/backoff/v4)) bundled(golang(github.com/containerd/errdefs)) bundled(golang(github.com/containerd/errdefs/pkg)) bundled(golang(github.com/containerd/log)) bundled(golang(github.com/containerd/platforms)) bundled(golang(github.com/cpuguy83/dockercfg)) bundled(golang(github.com/cpuguy83/go-md2man/v2)) bundled(golang(github.com/davecgh/go-spew)) bundled(golang(github.com/decred/dcrd/dcrec/secp256k1/v4)) bundled(golang(github.com/distribution/reference)) bundled(golang(github.com/docker/docker)) bundled(golang(github.com/docker/go-connections)) bundled(golang(github.com/docker/go-units)) bundled(golang(github.com/ebitengine/purego)) bundled(golang(github.com/felixge/httpsnoop)) bundled(golang(github.com/go-chi/chi/v5)) bundled(golang(github.com/go-jose/go-jose/v4)) bundled(golang(github.com/go-logr/logr)) bundled(golang(github.com/go-logr/stdr)) bundled(golang(github.com/go-ole/go-ole)) bundled(golang(github.com/goccy/go-json)) bundled(golang(github.com/gogo/protobuf)) bundled(golang(github.com/google/uuid)) bundled(golang(github.com/gorilla/securecookie)) bundled(golang(github.com/inconshreveable/mousetrap)) bundled(golang(github.com/jeremija/gosubmit)) bundled(golang(github.com/kballard/go-shellquote)) bundled(golang(github.com/klauspost/compress)) bundled(golang(github.com/kr/fs)) bundled(golang(github.com/lestrrat-go/blackmagic)) bundled(golang(github.com/lestrrat-go/httpcc)) bundled(golang(github.com/lestrrat-go/httprc)) bundled(golang(github.com/lestrrat-go/iter)) bundled(golang(github.com/lestrrat-go/jwx/v2)) bundled(golang(github.com/lestrrat-go/option)) bundled(golang(github.com/lufia/plan9stats)) bundled(golang(github.com/magiconair/properties)) bundled(golang(github.com/melbahja/goph)) bundled(golang(github.com/moby/docker-image-spec)) bundled(golang(github.com/moby/go-archive)) bundled(golang(github.com/moby/patternmatcher)) bundled(golang(github.com/moby/sys/sequential)) bundled(golang(github.com/moby/sys/user)) bundled(golang(github.com/moby/sys/userns)) bundled(golang(github.com/moby/term)) bundled(golang(github.com/morikuni/aec)) bundled(golang(github.com/muhlemmer/gu)) bundled(golang(github.com/muhlemmer/httpforwarded)) bundled(golang(github.com/opencontainers/go-digest)) bundled(golang(github.com/opencontainers/image-spec)) bundled(golang(github.com/openpubkey/openpubkey)) bundled(golang(github.com/pkg/errors)) bundled(golang(github.com/pkg/sftp)) bundled(golang(github.com/pmezard/go-difflib)) bundled(golang(github.com/power-devops/perfstat)) bundled(golang(github.com/rs/cors)) bundled(golang(github.com/russross/blackfriday/v2)) bundled(golang(github.com/segmentio/asm)) bundled(golang(github.com/shirou/gopsutil/v4)) bundled(golang(github.com/sirupsen/logrus)) bundled(golang(github.com/spf13/afero)) bundled(golang(github.com/spf13/cobra)) bundled(golang(github.com/spf13/pflag)) bundled(golang(github.com/stretchr/testify)) bundled(golang(github.com/testcontainers/testcontainers-go)) bundled(golang(github.com/thediveo/enumflag/v2)) bundled(golang(github.com/tklauser/go-sysconf)) bundled(golang(github.com/tklauser/numcpus)) bundled(golang(github.com/yusufpapurcu/wmi)) bundled(golang(github.com/zitadel/logging)) bundled(golang(github.com/zitadel/oidc/v3)) bundled(golang(github.com/zitadel/schema)) bundled(golang(go.opentelemetry.io/auto/sdk)) bundled(golang(go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp)) bundled(golang(go.opentelemetry.io/otel)) bundled(golang(go.opentelemetry.io/otel/exporters/otlp/otlptrace)) bundled(golang(go.opentelemetry.io/otel/metric)) bundled(golang(go.opentelemetry.io/otel/trace)) bundled(golang(go.opentelemetry.io/proto/otlp)) bundled(golang(golang.org/x/crypto)) bundled(golang(golang.org/x/exp)) bundled(golang(golang.org/x/mod)) bundled(golang(golang.org/x/net)) bundled(golang(golang.org/x/oauth2)) bundled(golang(golang.org/x/sys)) bundled(golang(golang.org/x/term)) bundled(golang(golang.org/x/text)) bundled(golang(gopkg.in/yaml.v3)) opkssh opkssh(x86-64) opkssh-server: config(opkssh-server) group(opkssh) opkssh-server user(opkssh) opkssh-server-selinux: opkssh-server-selinux opkssh-doc: opkssh-doc Diff spec file in url and in SRPM --------------------------------- --- /home/petro/rpmbuild/SPECS/2432005-opkssh/srpm/opkssh.spec 2026-02-28 17:57:10.166634859 +0100 +++ /home/petro/rpmbuild/SPECS/2432005-opkssh/srpm-unpacked/opkssh.spec 2026-02-22 01:00:00.000000000 +0100 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # Generated by go2rpm 1.18.0 %bcond check 1 @@ -149,3 +159,21 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Sun Feb 22 2026 Till Hofmann <[email protected]> - 0.13.0-1 +- Uncommitted changes + +* Thu Jan 22 2026 Till Hofmann <[email protected]> - 0.12.0-5 +- Remove 'opkssh' from summaries + +* Thu Jan 22 2026 Till Hofmann <[email protected]> - 0.12.0-4 +- Move docs into separate sub-package + +* Thu Jan 22 2026 Till Hofmann <[email protected]> - 0.12.0-3 +- Do not install docs not useful in a package + +* Thu Jan 22 2026 Till Hofmann <[email protected]> - 0.12.0-2 +- Drop redundant Provides + +* Thu Jan 22 2026 Till Hofmann <[email protected]> - 0.12.0-1 +- Drop golang- prefix from package name +## END: Generated by rpmautospec Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2432005 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Perl, C/C++, Haskell, SugarActivity, PHP, Python, Java, fonts, Ocaml, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH This package is ================ === APPROVED === ================ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432005 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432005%23c14 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
