https://bugzilla.redhat.com/show_bug.cgi?id=2386646
Artur Frenszek-Iwicki <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?([email protected] | |) | --- Comment #13 from Artur Frenszek-Iwicki <[email protected]> --- > * Build > - RPM build warnings: File listed twice: > /usr/share/peazip/share/copying/copying.txt Meh. rpmbuild magic that autoincludes some files. Fixed. > * With GTK2 being phased out and only really present for compatibilty. Do we > need to do a GTK2 build? I think it doesn't hurt having it. Should GTK2 get removed from the distro one day, disabling the GTK2 build here is trivial. Also, despite GTK3 also being quite old at the time, it's still considered "experimental" in Lazarus. > * 'copying_we.txt' - It's impact on the packages licensing? > - Other licenses relevant in package? Ah, good catch. The program uses some code by other authors, subject to Zlib. Also the -common subpackage contains some prebuilt .pdf documentation subject to GNU FDL. > * GUI apps should an appstream metinfo file. > - https://www.freedesktop.org/software/appstream/docs/ Upstream doesn't ship a metainfo file and I didn't feel like writing one myself, so I borrowed the file from Flathub. spec: https://suve.fedorapeople.org/review/peazip-10.9.0-2/peazip.spec srpm: https://suve.fedorapeople.org/review/peazip-10.9.0-2/peazip-10.9.0-2.fc43.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=142944327 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2386646 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202386646%23c13 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
