https://bugzilla.redhat.com/show_bug.cgi?id=2428750
--- Comment #6 from Carl George 🤠<[email protected]> --- The release field should use %autorelease, and the changelog should be generated by %autochangelog. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_release_tag https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs ================================================================================ It's not required, but the recommended source URL format for a GitHub tag should be: Source: %{url}/archive/%{version}/%{name}-%{version}.tar.gz This will let you avoid the URL fragment workaround. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags ================================================================================ Macro forms of system executables should not be used, so the instances of %{__install} should be replaced with just the install command. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros ================================================================================ Is it intentional that the same conf/shell-timeout file is in /etc/default and /usr/share/doc/shell-timeout? I'm not aware of any guidelines around this, it just struck me as odd so I wanted to check. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2428750 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202428750%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
