Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=696357 --- Comment #3 from Timur Kristóf <ti...@sch.bme.hu> 2011-04-15 01:59:17 EDT --- Hello Mohamed, thank you for reviewing! :) (In reply to comment #2) > * maybe your package should be renamed « gnome-shell-extension-fedora-logo » > or > « gnome-shell-fedora-logo Because if I named it like that, people would think that the package is provided by upstream (like gnome-shell-extensions), which is not the case. And if you look at any of such Fedora packages, all of them begin with either the name "fedora" or a release name. (examples: fedora-icon-theme, lovelock-backgrounds, laughlin-kde-theme, etc.) If you still think that the name needs to change, I will rename it. > * the fedora-logos package provides a « system-logos » capacity, as well as > the > generic-logos package (and probably the redhat-logos in RHEL also). Why not > setting system-logos as Requires instead of fedora-logos, so that your package > would be usable without any change in Fedora as well as in any > Fedora-derivated > distribution? Very good point, I wasn't aware of such a possibility. Currently the extension finds the logo by the icon name 'fedora-logo-icon'. If you tell me what icon name to use in order to utilize this system-logos capacity, I will gladly change it. :) > * about the URL tag: why not simply use http://sources.venemo.net/? The URL > tag > is intended to point to the project website, no matter how small it is. If > it's > not the solution you prefer, you could create a basic page in your > fedorapeople.org space (or wherever you can) containing the description of the > package and links to the sources. I think making a fedorapeople.org page is a good idea, I'll make one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review