https://bugzilla.redhat.com/show_bug.cgi?id=2484925
--- Comment #4 from Diego Herrera <[email protected]> --- (In reply to Miro Hrončok from comment #2) > Consider not using pyp2rpm at all, it creates oldfashioned Python specfiles. > Converting them to %pyproject macro is then usually error prone. > https://pypi.org/project/pyp2spec/ works quite nicely. :O! didn't knew about the new tool! I'll make sure to regenerate using that one :D Thx for the tip. > Please, don't use pylint during the build, see > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters > > Using %pyproject_wheel without % pyproject_buildrequires is not supported. > Noted! it seems that pyp2spec did filter that one out correctly > > Also, > > > License: None > > URL: None > > This is missing actual data. Woops, my mistake! > > %{?python_provide:%python_provide python3-%{pypi_name}} > > This is not needed. Fixed > > > %description -n python3-%{pypi_name} > > asdasdasd > > This feels like an error. It was an error! Thx for catching that one out xP > > # Remove bundled egg-info > > rm -rf %{pypi_name}.egg-info > > This is not needed. > Removed > > export PYTHONPATH=%{buildroot}%{python3_sitearch} > > This is also not needed, %pytest does that. Removed :thumbsup: ---- Spec URL: https://codeberg.org/dherrerace/python-ml-dtypes-rpm/raw/branch/main/python-ml-dtypes.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dherrera/onnx-devel/srpm-builds/10584187/python-ml-dtypes-0.5.4-3.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2484925 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202484925%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
