https://bugzilla.redhat.com/show_bug.cgi?id=2481458
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Ben Beasley <[email protected]> --- I independently reviewed this submission, and I confirm Srikrishna Veturi’s provisional review above. I would like to note that Srikrishna’s review is detailed, helpful, of high quality, and suggests a good understanding of applicable guidelines. I have only a couple of additional things to note, below. This submission is version 0.8.4 (the last release in the 0.8.x branch), while the newest upstream release is actually 0.9.2. This is justifiable because the package is being introduced to support hickory-proto, and the latest hickory-proto still wants prefix-trie 0.8. Because version 0.9 includes significant API changes, https://github.com/tiborschneider/prefix-trie/blob/v0.9.1/Readme.md#migrate-to-version-09, it makes sense to wait for hickory-proto upstream to do the migration work. You could exclude codecov.yml from the crate as unnecessary, and/or suggest that upstream do so. This is not very important since it’s a single, tiny file. The package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2481458 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202481458%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
