https://bugzilla.redhat.com/show_bug.cgi?id=2523675
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Ben Beasley <[email protected]> --- (In reply to Petr Menšík from comment #3) > it seems to me imgui is large enough to deserve its own separate package, > its upstream seem active enough. marking it with bundled(imgui) should be > only the minimal variant. The challenge with packaging imgui is that while it is not header-only, it provides no build system and no support for building it as a library, shared or otherwise; it is designed to be used as a large copylib or by including it as a git submodule. It might be possible to design a scheme where imgui is shipped source-only, packaging both the .hpp and .cpp files, and treated as a static library similar to a C++ header-only library, but the right way to do this is not obvious. In general, though, I strongly agree with your comments on bundled system libraries. The requirements in https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling for using bundled libraries are fairly strict and are nearly all MUST rather than SHOULD. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2523675 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202523675%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
