https://bugzilla.redhat.com/show_bug.cgi?id=2525617
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Ben Beasley <[email protected]> --- I investigated packaging this a while ago and ended up not needing it. It turns out you actually can run most of the tests. From the spec file I still had lying around: # Run tests that would require network access? We cannot do so in Koji, but we # can use something like # fedpkg mockbuild --enable-network --with network_tests # to try out these tests locally. %bcond network_tests 0 […] # See [envs.default.dependencies] in hatch.toml. We don’t need everything from # that list. %if %{with network_tests} BuildRequires: gcc %endif BuildRequires: %{py3_dist pytest} BuildRequires: %{py3_dist packaging} BuildRequires: %{py3_dist build[virtualenv]} […] %if %{without network_tests} # All of these require network access. ignore="${ignore-} --ignore=tests/test_build.py" ignore="${ignore-} --ignore=tests/test_clean.py" %else # Upstream expects a wheel name like: # my_app-1.2.3-cp314-cp314-manylinux_2_43_x86_64.whl # but we get something like: # my_app-1.2.3-cp314-cp314-linux_x86_64.whl # which is not incorrect; the discrepancy is an artifact of the RPM build # environment, and the tests work in a git checkout. It makes more sense to # skip these tests than to try to get upstream to support our environment. k="${k-}${k+ and }not test_no_exclusion" k="${k-}${k+ and }not test_exclusion" k="${k-}${k+ and }not test_separation" k="${k-}${k+ and }not test_src_layout" k="${k-}${k+ and }not test_dependency" k="${k-}${k+ and }not test_build_dir" %endif # Similarly, the following tests work in a git checkout, but in our environment # we get: # E ValueError: Unable to determine which files to ship inside the wheel # E using the following heuristics: # E https://hatch.pypa.io/latest/plugins/builder/wheel/#default-file-selection # E # E The most likely cause of this is that there is no directory that # E matches the name of your project (my_app). # This does not seem worth chasing down. k="${k-}${k+ and }not (TestPatternMatching and test_default_exclude)" k="${k-}${k+ and }not (TestPatternMatching and test_exclude)" %pytest -k "${k-}" ${ignore-} -v -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2525617 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202525617%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
