https://bugzilla.redhat.com/show_bug.cgi?id=2527623
Mamoru TASAKA <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Mamoru TASAKA <[email protected]> --- Well: * Not blockers - I don't think ">= 3.0.0" part in "BuildRequires: ruby" is needed. We no longer support such old rubies. - I suggest moving "README.md" to main package: I think the author expects this to be read at first. Please consider above. * spec file clean * license correct * BR / Requires correct * builds successfully https://koji.fedoraproject.org/koji/taskinfo?taskID=149847022 * installation successful * Minimum usablily test works: $ ruby -e "require 'factory_bot' ; puts FactoryBot::VERSION" 6.6.0 ====================================================== This package (rubygem-factory_bot) is APPROVED by mtasaka ====================================================== -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2527623 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202527623%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
