https://bugzilla.redhat.com/show_bug.cgi?id=2526473
Mamoru TASAKA <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+ --- Comment #3 from Mamoru TASAKA <[email protected]> --- Okay. * Not blockers: you may consider the followings (again not blockers) - I don't think ">= 2.4.0" part in "BuildRequires: ruby" is needed: we no longer support such old rubies. - "Rakefile" in ruby system is something like Makefile in autotools system, so this is basically for development purpose, so I don't think this file is needed - I don't think "Gemfile" is useful for packaging. - Well, please check if the files under %{gem_instdir}/bin (i.e. "console" and "setup") are really needed: perhaps they are unneeded. - spec file clean - license correct - source file matches the upstream (sha512sum: c4b29038ada8954ccebf73f9737db0eb7fd62a1fcf980440b696e960f58900a16a6a7397ab76c253dd36607b078dd7c2fc00acd40163b18b3d5bfc0e47fae8b9) - builds cleanly on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=149967784 - tests are executed - installs successfully - minimum functionality works: $ ruby -e 'require "psych/comments" ; puts Psych::Comments::VERSION' 0.1.1 ================================================= This package (rubygem-psych-comments) is APPROVED by mtasaka ================================================= -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2526473 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202526473%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
