https://bugzilla.redhat.com/show_bug.cgi?id=2519469
--- Comment #12 from Luca Albrecht <[email protected]> --- (In reply to Mamoru TASAKA from comment #11) > Please address what other people pointed out, e.g. > > (In reply to Steve Traylen from comment #1) > > Requires: rubygem-optimist > > > > * The indentation of this line is inconsistent with the other lines in the > > header. > > * Why is this line here at all ? `Requires` should normally auto computed > > from the gemspec.... ? > > > > * I would say https://github.com/voxpupuli/hiera-eyaml/ was a better URL > > than the rubygems one since that is the package's homepage. Hi Mamoru, I have already addressed the comment that you are speaking of (Comment 6). As far as I can tell, there is no more unaddressed feedback. Unless I missed something? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2519469 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202519469%23c12 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
