https://bugzilla.redhat.com/show_bug.cgi?id=2525945

Artur Frenszek-Iwicki <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Artur Frenszek-Iwicki <[email protected]> ---
> BuildRequires:  pcre2-devel
> BuildRequires:  json-c-devel
> BuildRequires:  gtest-devel
Consider using "BuildRequires: pkgconfig(libpcre2-32) pkgconfig(json-c)
pkgconfig(gtest)" instead.

> %files -n libtextparser
> %{_libdir}/libtextparser.so.*
Don't. This makes it easy to miss a SONAME bump happening.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files

Also, since you're splitting the libs into libtextparser and
libtextparser-json, might be worth to add
"Provides: libtextparser-json-devel%{?_isa} = %{version}-%{release}" to the
-devel package.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2525945

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202525945%23c1

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to