https://bugzilla.redhat.com/show_bug.cgi?id=2529585
--- Comment #4 from Peter Lemenkov <[email protected]> --- Thanks! (In reply to Jerry James from comment #3) ... > Issues: > ======= > - There is one additional license: BSD-3-Clause, for > src/ejabberd_websocket.erl Done. > - The ejabberd-selinux package can be installed without also installing the > main ejabberd package. In that case, no license file is installed. > > I don't understand why there are 2 packages in any case. They are both > noarch, and the main package Requires the selinux subpackage. Why not put > everything into one package? Agree. I removed the selinux-subpackage. > - Do you know what is going on with /usr/share/selinux/devel/include/contrib? > The selinux-policy-devel package owns that directory, but is not Required > by ejabberd-selinux. Note also the selinux-incorrect-if-file-location > warning from rpmlint. No idea. I suspect there is a room for SELinux packaging improvements. I'll try to improve this situation in the future. Right now I just do what we had already which is supposedly works. > - The syntax of the VCS tag is incorrect. According to > https://rpm.org/docs/6.1.x/manual/tags.html#informative-package-tags: > > "(Public) upstream source code VCS location. Format <vcs>:<address> with > <vcs> being the VCS command used (e.g. git, svn, hg, …) and <address> > being > the location of the repository as used by the VCS tool to clone/checkout > the > repository (e.g. https://github.com/rpm-software-management/rpm.git)." > > So the "scm:" prefix is incorrect and should be removed. Fixed. > - Please let upstream know about the incorrect-fsf-address rpmlint warnings. > The FSF uses a web address instead of a street address in their license > files > to avoid exactly this problem. See > https://www.gnu.org/licenses/old-licenses/gpl-2.0.html for the current > GPL-2.0 text. Will do, thanks! Updated SPEC-file and SRPM: Spec URL: https://peter.fedorapeople.org/packages/re-review/ejabberd.spec SRPM URL: https://peter.fedorapeople.org/packages/re-review/ejabberd-26.07-2.fc46.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2529585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202529585%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
