https://bugzilla.redhat.com/show_bug.cgi?id=2529728
Cristian Le <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(susi.lehtola@iki. | |fi) --- Comment #9 from Cristian Le <[email protected]> --- @[email protected] I know you find "ack" replies to be a waste of time, but others can view selectively replying only to parts of a comment rude, especially when it happens regularly. Anyway, please re-read the Versioning packaging guidelines, particularly in the usage of `~` and `^`, and the snapshot metadata in `Version`. Beware that one is for post and the other for pre releases. > It's buildable, just requiring one more build dependency, emacs, to generate > code from org files. But for released tarball emacs is not needed. That does not seem to be intended, particularly since `TREXIO_DEVEL` is not passed and `TREXIO_MOD_FILE` generation is gated in there. I don't think I want to know why `build_trexio.sh` is being run in that logic, especially since upstream is deeming the `TREXIO_DEVEL` approach unsuited for a release anyway. As for the python packaging, building these from CMake only misses the `-dist-info` metadata that contain the dependencies as well as the package presence when doing something like `pip list`. Please see the `setup.py` and check if it can be run against a pre-installed trexio build-dir. I would rather recommend them to move it to `scikit-build-core` and have a proper build-system to detect trexio library. See spglib if you want a reference for how to design the cmake project to support that. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2529728 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202529728%23c9 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
