Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699902 Robin Lee <robinlee.s...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |robinlee.s...@gmail.com AssignedTo|nob...@fedoraproject.org |robinlee.s...@gmail.com Flag| |fedora-review? --- Comment #1 from Robin Lee <robinlee.s...@gmail.com> 2011-04-27 00:16:28 EDT --- Here is the review: +:ok, =:needs attention, -:needs fixing MUST Items: [+] MUST: rpmlint must be run on every package. $ rpmlint ./RPMS/noarch/python-manuel-1.5.0-1.fc15.noarch.rpm ./SRPMS/python-manuel-1.5.0-1.fc14.src.rpm ./SPECS/python-manuel.spec python-manuel.noarch: W: spelling-error %description -l en_US doctests -> doc tests, doc-tests, doctorates python-manuel.src: W: spelling-error %description -l en_US doctests -> doc tests, doc-tests, doctorates 2 packages and 1 specfiles checked; 0 errors, 2 warnings. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name} [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ md5sum manuel-1.5.0.tar.gz 644fe14c164a6e78bcbc346fefbcd7a6 manuel-1.5.0.tar.gz [+] MUST: The package must successfully compile and build into binary rpms on at least one supported architecture. [+] MUST: All build dependencies must be listed in BuildRequires [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A package must not contain any duplicate files in the %files listing. [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. [+] MUST: The package must contain code, or permissible content. This is described in detail in the code vs. content section of Packaging Guidelines. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. SHOULD Items: [+] SHOULD: The reviewer should test that the package functions as described. [+] SHOULD: Packages should try to preserve timestamps of original installed files. Other Items: [-] According to setup.py, this package does not require python-zope-testing at runtime. [=] Group better be Development/Libraries [-] The text files in python site path are compiled to html by sphinx and included in %doc. They should be excluded from python site path. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
