Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=701031 --- Comment #5 from Deji Akingunola <dakin...@gmail.com> 2011-05-01 22:26:19 EDT --- I really appreciate you doing this review, but; > No, unfortunately not: > (In reply to comment #1) > > Please use macros consistently and as many as possible, as follows: > > There is no inconsistency in using macros in the spec file, writing out the file names explicitly in the filelist is OK. > > URL: https://launchpad.net/%{name} > >... > > > > %{_bindir}/%{name} > > %{_mandir}/man1/%{name}.* > > %{_sysconfdir}/xdg/autostart/%{name}.desktop > > > > ... There is no guideline/rules against explicitly listing buildrequires, in fact it I know of a number of packagers who prefer it that way. The buildrequires for this package is small enough, that I will like to continue to list them all explicitly. > > You have to drop glib2-devel and gettext from BuildRequires. They are > > recursive > > dependencies of gtk2-devel and intltool, respectively. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
