Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701112

Kalev Lember <ka...@smartlink.ee> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |ka...@smartlink.ee
         AssignedTo|nob...@fedoraproject.org    |ka...@smartlink.ee
          QAContact|extras...@fedoraproject.org |ka...@smartlink.ee
               Flag|                            |fedora-review?

--- Comment #2 from Kalev Lember <ka...@smartlink.ee> 2011-05-03 16:10:38 EDT 
---
Taking for review.

- There are a bunch of %defines just above the %build section that duplicate
the
  %globals at the top of the file.

- The package isn't building the -debuginfo subpackage.

- There's a new 2.8.12 release available; can you update to it?

- The BuildRoot tag, the whole %clean section, the 'rm -rf $RPM_BUILD_ROOT' at
  the beginning of %install, and the %deffattr lines are no longer required on
  current Fedora releases.

- It BuildRequires the mingw32-libpng package, but the configure script doesn't
  seem to like the png library:
configure: WARNING: system png library not found or too old, will use built-in
instead

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to