Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701932

Daiki Ueno <du...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: pymacs -    |Review Request:
                   |Emacs and Python            |emacs-pymacs - Emacs and
                   |integration framework       |Python integration
                   |                            |framework
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Daiki Ueno <du...@redhat.com> 2011-05-10 05:30:35 EDT ---
It looks fine except that:

- Requires: should be "emacs(bin) >= %{_emacs_version}"
- You could use %{name} instead of emacs-%{pkg} everywhere
- The license looks GPLv2+ as far as I checked the files in the source tree

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to