Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=703322

Martin Gieseking <martin.giesek...@uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.giesek...@uos.de

--- Comment #11 from Martin Gieseking <martin.giesek...@uos.de> 2011-05-13 
02:10:41 EDT ---
Hi Jesus,

there are several places where Vim looks for syntax files. The versioned
folders /usr/share/vim/vimXX usually contain only the files bundled with the
corresponding Vim release. If you want to install third-party syntax files, you
should put them into /usr/share/vim/vimfiles/syntax/ owned by package
vim-filesystem (available since Fedora 14). Shipping them as doc files forces
the user to manually copy them to ~/.vim/syntax.

The emacs files should be placed in %{_emacs_sitelispdir}/ (owned by
emacs-filesystem starting with Fedora 15). You also have to byte-compile it as
described in
http://fedoraproject.org/wiki/Packaging:Emacs#Case_II:_Package_also_provides_auxiliary_.28X.29Emacs_files

Please move the iconv loop to the %prep section.

If you don't plan to maintain the package for EPEL < 6, you can drop all the
buildroot stuff (BuildRoot field, %clean section, initial cleaning of the
buildroot in %install).

I suggest to add -m 644 to the install statement of the manpage and drop %attr
in %files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to