Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=701183 --- Comment #2 from Petr Pisar <ppi...@redhat.com> 2011-05-13 08:46:17 EDT --- Source tar ball is original. Ok. Summary verified from RateLimit.pm. Ok. License verified from RateLimit.pm. Ok. Description verified from RateLimit.pm. Ok. No XS used, noarch BuildArch is Ok. Missing version specifier at perl(CGI::Application) and perl(Class::Accessor) are acceptable as all Fedoras fulfill them. Ok. FIX: BuildRequire on perl(Class::Accessor::Fast) instead of perl(Class::Accessor) as Class::Accessor::Fast is used in code (RateLimit.pm:26) FIX: BuildRequire perl(DBI) because of tests (t/02simple.t:15) FIX: BuildRequire perl(File::Temp) because of tests (t/02simple.t:16) TODO: Remove obsolete BuildRoot cleaning in %install section. TODO: Remove already implicit %defattr in %files section. All tests pass. Ok. $ rpmlint perl-CGI-Application-Plugin-RateLimit.spec ../SRPMS/perl-CGI-Application-Plugin-RateLimit-1.0-1.fc14.src.rpm ../RPMS/noarch/perl-CGI-Application-Plugin-RateLimit-1.0-1.fc14.noarch.rpm perl-CGI-Application-Plugin-RateLimit.src: W: spelling-error Summary(en_US) runmode -> run mode, run-mode, Runnymede perl-CGI-Application-Plugin-RateLimit.src: W: spelling-error %description -l en_US runmode -> run mode, run-mode, Runnymede perl-CGI-Application-Plugin-RateLimit.noarch: W: spelling-error Summary(en_US) runmode -> run mode, run-mode, Runnymede perl-CGI-Application-Plugin-RateLimit.noarch: W: spelling-error %description -l en_US runmode -> run mode, run-mode, Runnymede 2 packages and 1 specfiles checked; 0 errors, 4 warnings. TODO: Correct `runmode' spelling to dictionary form (e.g. run-mode). The `runmode' is used in perl-CGI domain thus I consider this flaw as non-blocking. rpmlint Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-CGI-Application-Plugin-RateLimit-1.0-1.fc14.noarch.rpm drwxr-xr-x 2 root root 0 kvě 13 14:24 /usr/share/doc/perl-CGI-Application-Plugin-RateLimit-1.0 -rw-r--r-- 1 root root 208 kvě 4 2006 /usr/share/doc/perl-CGI-Application-Plugin-RateLimit-1.0/Changes -rw-r--r-- 1 root root 885 kvě 4 2006 /usr/share/doc/perl-CGI-Application-Plugin-RateLimit-1.0/README -rw-r--r-- 1 root root 5064 kvě 13 14:24 /usr/share/man/man3/CGI::Application::Plugin::RateLimit.3pm.gz drwxr-xr-x 2 root root 0 kvě 13 14:24 /usr/share/perl5/CGI drwxr-xr-x 2 root root 0 kvě 13 14:24 /usr/share/perl5/CGI/Application drwxr-xr-x 2 root root 0 kvě 13 14:24 /usr/share/perl5/CGI/Application/Plugin -rw-r--r-- 1 root root 15984 kvě 4 2006 /usr/share/perl5/CGI/Application/Plugin/RateLimit.pm File permissions and layout Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-CGI-Application-Plugin-RateLimit-1.0-1.fc14.noarch.rpm |sort |uniq -c 1 perl(base) 1 perl(Carp) 1 perl(:MODULE_COMPAT_5.12.3) 1 perl(strict) 1 perl(warnings) 1 perl >= 0:5.006 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 2 rpmlib(VersionedDependencies) <= 3.0.3-1 FIX: Require perl(Class::Accessor::Fast) explicitly as it's not discovered by rpmbuild (RateLimit.pm:26) TODO: Require perl(CGI::Application) explicitly as this module is extension for that class. $ rpm -q --provides -p ../RPMS/noarch/perl-CGI-Application-Plugin-RateLimit-1.0-1.fc14.noarch.rpm |sort |uniq -c 1 perl(CGI::Application::Plugin::RateLimit) = 1.0 1 perl-CGI-Application-Plugin-RateLimit = 1.0-1.fc14 Binary provides Ok. Package builds in F16 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3069506). Ok. Otherwise package is in line with Fedora and perl packaging guidelines. Please correct all `FIX' prefixed issues, considier fixing `TODO' issues and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
