Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=669146 --- Comment #12 from Ankur Sinha <sanjay.an...@gmail.com> 2011-05-28 05:41:44 EDT --- (In reply to comment #11) > 1. This is a server, not a GUI. Okay > 2. Not compressing man pages gives error. It doesn't. rpmbuild does automagically gzip the man pages. I made this change to your spec: #for man in `ls doc/*.*`; \ # do gzip $man; \ #done #cp -p doc/*.8.gz %{buildroot}%{_mandir}/man8 #cp -p doc/*.1.gz %{buildroot}%{_mandir}/man1 cp -p doc/*.8 %{buildroot}%{_mandir}/man8 cp -p doc/*.1 %{buildroot}%{_mandir}/man1 and built the resulting srpm in mock. This is what I got: [ankur@ankur SRPMS]$ rpm -qd /var/lib/mock/fedora-rawhide-i386/result/gnumed-server-14.8-1.fc16.noarch.rpm -p /usr/share/doc/gnumed-server/GnuPublicLicense.txt /usr/share/doc/gnumed-server/README /usr/share/doc/gnumed-server/schema/gnumed-schema-no_audit.dot /usr/share/doc/gnumed-server/schema/gnumed-schema.html /usr/share/man/man1/gm-remove_person.1.gz /usr/share/man/man8/gm-adjust_db_settings.8.gz /usr/share/man/man8/gm-backup_data.8.gz /usr/share/man/man8/gm-backup_database.8.gz /usr/share/man/man8/gm-bootstrap_server.8.gz /usr/share/man/man8/gm-fixup_server.8.gz /usr/share/man/man8/gm-set_gm-dbo_password.8.gz /usr/share/man/man8/gm-upgrade_server.8.gz Looks okay :) > 3. All other comments taken care of. About the gpl patch. Is it really required? Just including a License as SOURCE1 wouldn't suffice? > > 4. > > $rpmlint RPMS/noarch/gnumed-server-14.8-1.fc14.noarch.rpm gives > gnumed-server.noarch: E: incorrect-fsf-address > /usr/share/doc/gnumed-server/GnuPublicLicense.txt > > This is more of an annoyance I guess. I've asked the devel list on how one should be handling this. We'll probably have to patch it to the new address. Some tweaks are needed to the files section. There are unowned directories. This is what it should look like: %defattr(-,root,root,-) %doc %{_defaultdocdir}/%{name}/ %{_sharedstatedir}/%{name}/ %{_bindir}/gm-* %{_mandir}/man8/gm-* %{_mandir}/man1/gm-* %config(noreplace) %{_sysconfdir}/%{name}/ In %defattr(-,root,root,-) %doc %{_defaultdocdir}/%{name}/* %{_sharedstatedir}/%{name}/* %{_bindir}/gm-* %{_mandir}/man8/gm-* %{_mandir}/man1/gm-* %config(noreplace) %{_sysconfdir}/%{name}/* the %doc %{_defaultdocdir}/%{name}/ %{_sharedstatedir}/%{name}/ %config(noreplace) %{_sysconfdir}/%{name}/ directories are unowned. The BuildRoot tag isn't required anymore. Please comment on the patches in the spec. These look like the only issues. I'll do a full review again by monday. Thanks, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
